Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Sentry secrets on CI #21706

Open
igor-sirotin opened this issue Nov 28, 2024 · 7 comments
Open

Setup Sentry secrets on CI #21706

igor-sirotin opened this issue Nov 28, 2024 · 7 comments
Assignees

Comments

@igor-sirotin
Copy link
Contributor

igor-sirotin commented Nov 28, 2024

Sentry integration is done here: status-im/status-go#6054

Description

We want to keep Sentry DSN private, so we need to provide some environment variables on CI.

The following env vars need to be defined on PRODUCTION CI only.
Not for PR-level or develop builds.

  • set SENTRY_DSN_STATUS_GO to the DSN from here
  • set SENTRY_PRODUCTION to true
@jakubgs
Copy link
Member

jakubgs commented Nov 28, 2024

Depends on:

So for now it's on hold.

@ilmotta
Copy link
Contributor

ilmotta commented Dec 2, 2024

Depends on:

So for now it's on hold.

@jakubgs @markoburcul the implementation in PR #21682 should work because I tested it locally pointing to a cloud Sentry instance. So we can proceed with this issue.

In status-desktop the make target building status-go is passing two new env vars SENTRY_CONTEXT_NAME and SENTRY_CONTEXT_VERSION. We need to do the same to build status-go for mobile. Could you assist me in how to implement this in status-go/mobile/build.nix? Actually, I would greatly appreciate if you could do the implementation on the nix layer 😅 Please, let me know if this is reasonable on your end. Thanks in advance 🙏🏼

The value for SENTRY_CONTEXT_NAME should be status-mobile and SENTRY_CONTEXT_VERSION should be whatever value is in the VERSION file, just as was implemented in status-desktop AFAIU.

Once this issue #21706 is resolved I will proceed to rebase develop onto #21682


@igor-sirotin in status-desktop it appears that SENTRY_ENVIRONMENT is not being used, only the env var SENTRY_PRODUCTION. In status-mobile I opted to follow the table documented in status-go to define the values of SENTRY_ENVIRONMENT for each .env.* file. Is that the idea or have I misunderstood something?

@markoburcul
Copy link

Could you assist me in how to implement this in status-go/mobile/build.nix?

I don't see that file, do you want to create it or? Since in status-desktop as I can see those two env variables are passed in the Makefile.

@ilmotta
Copy link
Contributor

ilmotta commented Dec 3, 2024

Could you assist me in how to implement this in status-go/mobile/build.nix?

I don't see that file, do you want to create it or? Since in status-desktop as I can see those two env variables are passed in the Makefile.

Thanks @markoburcul. The file is in this status-mobile repo at nix/status-go/mobile/build.nix, but when I copied I accidentally removed the parent path nix/.

@markoburcul
Copy link

Thanks @markoburcul. The file is in this status-mobile repo at nix/status-go/mobile/build.nix, but when I copied I accidentally removed the parent path nix/.

could you give me a link to this file on Github?

@ilmotta
Copy link
Contributor

ilmotta commented Dec 3, 2024

Thanks @markoburcul. The file is in this status-mobile repo at nix/status-go/mobile/build.nix, but when I copied I accidentally removed the parent path nix/.

could you give me a link to this file on Github?

@markoburcul it's this file

@igor-sirotin
Copy link
Contributor Author

in status-desktop it appears that SENTRY_ENVIRONMENT is not being used, only the env var SENTRY_PRODUCTION.

@ilmotta indeed, yes. I didn't bother with other environments for now, because we don't yet report to sentry from e2e tests.
I'll do the same later when we will set it up for tests.

I opted to follow the table documented in status-go

markoburcul added a commit that referenced this issue Dec 5, 2024
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
markoburcul added a commit that referenced this issue Dec 5, 2024
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
markoburcul added a commit that referenced this issue Dec 6, 2024
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
markoburcul added a commit that referenced this issue Dec 6, 2024
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
ilmotta pushed a commit that referenced this issue Dec 6, 2024
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
ilmotta pushed a commit that referenced this issue Dec 9, 2024
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
markoburcul added a commit that referenced this issue Dec 9, 2024
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
ilmotta pushed a commit that referenced this issue Dec 9, 2024
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
ilmotta pushed a commit that referenced this issue Dec 10, 2024
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
ilmotta pushed a commit that referenced this issue Dec 10, 2024
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
ilmotta pushed a commit that referenced this issue Dec 10, 2024
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
ilmotta pushed a commit that referenced this issue Dec 12, 2024
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
markoburcul added a commit that referenced this issue Jan 2, 2025
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
ilmotta pushed a commit that referenced this issue Jan 6, 2025
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
markoburcul added a commit that referenced this issue Jan 13, 2025
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
siddarthkay pushed a commit that referenced this issue Jan 23, 2025
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
siddarthkay pushed a commit that referenced this issue Jan 27, 2025
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
ilmotta pushed a commit that referenced this issue Jan 29, 2025
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
ilmotta pushed a commit that referenced this issue Feb 2, 2025
referenced issue: #21706

Signed-off-by: markoburcul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants