Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: how do I decide between auto, reload, and search/match? #663

Open
aqeelat opened this issue May 13, 2024 · 4 comments
Open

Question: how do I decide between auto, reload, and search/match? #663

aqeelat opened this issue May 13, 2024 · 4 comments
Labels
kind/enhancement New feature or request

Comments

@aqeelat
Copy link

aqeelat commented May 13, 2024

I have a bunch of helm charts deployments, most with their own configmap/secret. I also have a couple of shared secrets and configmaps.

The current configmaps and secrets have the same name as the deployment.

My options:

  1. auto. I will have to rename everything which is fine, but this will not cover the shared stuff, and will not cover envFrom.
  2. reload. I could also use some jujitsu templating (or statically) and add the names of all configmaps/secrets used in each deployment.
  3. search/match. I could also slap search/match on everything and call it a day.

In my situation, the first option does not seem like a good idea.
The third option is very appealing, but are there performance implications?
If the third option is out, then reload will be the winning option.

@aqeelat aqeelat added the kind/enhancement New feature or request label May 13, 2024
@SheryarButt
Copy link
Contributor

Hi @aqeelat
Have you tried the first approach?
And why do you have to rename everything?

@bnallapeta
Copy link

@aqeelat let us know if you need any further help from our end on this.

@h-mavrodiev
Copy link

h-mavrodiev commented Jun 28, 2024

Hi @SheryarButt ,
I am in a similar situation as @aqeelat.
From the Reloader documentation it seems like if you go for the first approach it does the config map/ secret discovery by name -> if your deployment is called FOO, it reads from the docs that you NEED secret/confMap named FOO for the Reloader to work.
If that's the case, if your config maps and secrets are not named as the Reloaded expects them to be, you would need to rename everything in order to use the first approach. It also would not work if different Deployments are sharing secrets or config map. In that situation, it seems that the only option would be to use approach 2.

Is that so, or does the discovering of which secret/confMaps is used by a Deployment works differently?

@SheryarButt
Copy link
Contributor

Hi @h-mavrodiev
The documentation doesn't say that you NEED to have the secret/config map named FOO, it's just an example to make things easier for beginners. We'll update the docs to resolve this ambiguity as well.

For the actual solution, no you don't have to name the secret/config map to be the same as the deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants