Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node versions beyond 10 cause build issues? #3

Open
mkellogg91 opened this issue Jun 4, 2020 · 2 comments
Open

node versions beyond 10 cause build issues? #3

mkellogg91 opened this issue Jun 4, 2020 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@mkellogg91
Copy link

did not try anywhere close to all the versions beyond node version 10, however, I did try versions: 12.17.0 and 14.3.0 and both failed to build with the following error:

(node:24174) UnhandledPromiseRejectionWarning: Error: Cannot find module '@babel/compat-data/corejs3-shipped-proposals'

once I switched to v10.21.0 via nvm it built correctly.
Note: I am running this on centos 7.8

@maihde
Copy link
Contributor

maihde commented Jun 23, 2020

@mkellogg91 - the projects .nvmrc indicates that node v10.18.0 is the supported version. If you aren't already using nvm I highly recommend it because many projects use this convention and then you can just execute nvm use and you are confident you are running on a supported version.

That said, the root cause is a fundamental issue that has affected many projects; Ember being one of them. Basically the resolution is to force using the latest version of babel/preset-env. I've updated .nvmrc. to the latest LTS (12.18.1) and also updated package.json` to force the latest babel subpackage.

nvm use
rm -rf node_modules
yarn install
npm start

Try updating and following the above instructions and let me know if it fixes your issue.

@mkellogg91
Copy link
Author

thanks Mike, I was able to get it running and nvm is my friend :). I didn't realize a supported version was stated.

I've got two easy recommendations that tripped me up when setting up this project locally. They could be common sense for others, but here goes:

  1. I didn't know after running "docker make" to check my actual image version so I was trying to run a docker image according to "sds:0.1" in the readme instead of "sds:0.4"
  2. would be helpful if the readme just had a note indicating the supported node version

@mrecachinas mrecachinas added the documentation Improvements or additions to documentation label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants