Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

[Accessibility]: Branch/Tag/Commit + Repositories selector: Focus lost on ESC key #35476

Closed
2 of 4 tasks
umpox opened this issue May 16, 2022 · 1 comment
Closed
2 of 4 tasks
Assignees
Labels
accessibility a11y / accessibility estimate/1d frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. wcag/2.1/fixing wcag/2.1

Comments

@umpox
Copy link
Contributor

umpox commented May 16, 2022

Audit type

Keyboard navigation

User journey audit issue

https://github.com/sourcegraph/sourcegraph/issues/34417, https://github.com/sourcegraph/sourcegraph/issues/34416

Problem description

Closing these selectors/popovers should return the focus to the trigger that opened them. It seems that focus is completely lost currently and goes to the first element on the page. This seems to be an issue on quite a few popovers so I have grouped these together.

Expected behavior

Focus should be returned to the trigger element that opened the selector/popover.

Additional details

No response

Assigning labels

  • Please give this issue an estimate by applying a label like estimate/Xd, where X is the estimated number of days it will take to complete.
  • If this issue is specific to a specific Sourcegraph product, please assign the appropriate team label to this issue.
  • If this issue will require input from designers in order to complete, please assign the label needs-design.
  • If you are confident that this issue should be fixed by GitStart, please assign the label gitstart.

Owner

This issue will be fixed by my team, I have assigned a relevant member to it, or I will do so in the near future.

@umpox umpox added accessibility a11y / accessibility estimate/1d frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. wcag/2.1/fixing wcag/2.1 labels May 16, 2022
@umpox umpox self-assigned this May 16, 2022
@umpox umpox changed the title [Accessibility]: Branch/Tag/Commit + Repositories selector: Focus lost on <kbd>ESC</kbd> key [Accessibility]: Branch/Tag/Commit + Repositories selector: Focus lost on ESC key May 16, 2022
@vovakulikov vovakulikov assigned vovakulikov and unassigned umpox Nov 8, 2022
@vovakulikov
Copy link
Contributor

It was fixed with this PR about improving Popover UI https://github.com/sourcegraph/sourcegraph/pull/43029

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility a11y / accessibility estimate/1d frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. wcag/2.1/fixing wcag/2.1
Projects
No open projects
Status: Done
Status: Done
Development

No branches or pull requests

2 participants