Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate message on network interrupt #5

Open
daniel-lerch opened this issue Oct 5, 2019 · 2 comments
Open

Duplicate message on network interrupt #5

daniel-lerch opened this issue Oct 5, 2019 · 2 comments
Assignees
@Twometer
Labels
bug Something isn't working

Comments

@daniel-lerch
Copy link
Member

Describe the bug
The automatic message send retry can lead to duplicate messages when the client looses connection.

To Reproduce
Steps to reproduce the behavior:

  1. Get a slow internet connection
  2. Send a message
  3. Disconnect while sending
  4. Reconnect
  5. A duplicate message will appear for everyone

Expected behavior
The client should wait for the server's SyncFinished and check whether the message has been transferred and retry only if not. If you need to know the temporary message ID to implement this behaviour, please file an issue at skynet-im/skynet.
@daniel-lerch daniel-lerch added the bug Something isn't working label Oct 5, 2019
@Twometer Twometer self-assigned this Oct 6, 2019
@Twometer
Copy link
Member

Twometer commented Oct 6, 2019

I have changed the sending code recently without extensively testing the retry afterwards. I will look into this

@Twometer
Copy link
Member

Does this still occur with the latest release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Twometer Twometer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Twometer @daniel-lerch