Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use channel updates to chose a keypair #16

Open
daniel-lerch opened this issue Feb 17, 2020 · 1 comment
Open

Use channel updates to chose a keypair #16

daniel-lerch opened this issue Feb 17, 2020 · 1 comment
Assignees
@Twometer
Labels
enhancement New feature or request

Comments

@daniel-lerch
Copy link
Member

Currently all messages are just encrypted and decrypted using the latest keypair of the respective channel. This implementation is not suitable if keypairs should be dynamic and easy to change. Future server implementations will at least enforce clients to reference a recent channel update message as dependency.
@daniel-lerch daniel-lerch added the enhancement New feature or request label Feb 17, 2020
@daniel-lerch daniel-lerch mentioned this issue Feb 17, 2020
Merged
@daniel-lerch
Copy link
Member Author

While reviewing a pull request I noticed that the Skynet app always takes the latest keypair for the respective channel and does not even respect MessageFlags.Loopback. Although this will not lead to crashes or corrupted messages, it violates the protocol rules and will not be compatible with other client implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Twometer Twometer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Twometer @daniel-lerch