From b0f637c093dd908a5c6a847c808a9cd06ea95821 Mon Sep 17 00:00:00 2001 From: Jon Surrell Date: Tue, 25 Jun 2024 18:24:58 +0200 Subject: [PATCH] Remove legacy webpack DefinePlugin configuration https://github.com/WordPress/gutenberg/pull/61486 changed the variables compiled into Gutenberg packages via the webpack DefinePlugin. https://core.trac.wordpress.org/changeset/58193 added the new DefinePlugin configuration, but did not remove the legacy configuration in order to be compatible with new and old Gutenberg versions before the packages were updated. Now that packages have been update, the legacy configuration should be removed. Closes https://core.trac.wordpress.org/ticket/61262. Follow-up to https://core.trac.wordpress.org/changeset/58193. --- tools/webpack/shared.js | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/tools/webpack/shared.js b/tools/webpack/shared.js index ec12959351151..9cfd335176492 100644 --- a/tools/webpack/shared.js +++ b/tools/webpack/shared.js @@ -41,15 +41,6 @@ const getBaseConfig = ( env ) => { watch: env.watch, plugins: [ new DefinePlugin( { - /* - * These variables are part of https://github.com/WordPress/gutenberg/pull/61486 - * They're expected to be released in an upcoming version of Gutenberg. - * - * Defining this before the packages are released is harmless. - * - * @todo Remove the non-globalThis defines here when packages have been upgraded to the globalThis versions. - */ - // Inject the `IS_GUTENBERG_PLUGIN` global, used for feature flagging. 'globalThis.IS_GUTENBERG_PLUGIN': JSON.stringify( false ), // Inject the `IS_WORDPRESS_CORE` global, used for feature flagging. @@ -58,13 +49,6 @@ const getBaseConfig = ( env ) => { 'globalThis.SCRIPT_DEBUG': JSON.stringify( mode === 'development' ), - - // Inject the `IS_GUTENBERG_PLUGIN` global, used for feature flagging. - 'process.env.IS_GUTENBERG_PLUGIN': JSON.stringify( false ), - // Inject the `IS_WORDPRESS_CORE` global, used for feature flagging. - 'process.env.IS_WORDPRESS_CORE': JSON.stringify( true ), - // Inject the `SCRIPT_DEBUG` global, used for dev versions of JavaScript. - SCRIPT_DEBUG: JSON.stringify( mode === 'development' ), } ), ], };