[on-prem] Node group names don't support dashes (-)

[ralgozino]

Describe the bug

Using a dash (hyphen) - the name of a node group, for example:

spec:
  kubernetes:
    nodes:
      - name: ingress-external
        hosts:
          ...

results in the following Ansible error:

[WARNING]: Invalid characters were found in group names but not replaced, use -vvvv to see details

To Reproduce

Steps to reproduce the behavior:

1. Create a furyctl.yaml
2. Add a node group with the name containing a dash -.
3. Apply the configuration
4. See error

Expected behavior

A think using - should be supported, it is a very common use case. Maybe we should replace the dashes for underscores in the hosts.yaml template file.

If we can't support them, we should update the schema to fail at validation-time instead of at apply-time.

Software versions

Please complete the following information:

• Kubernetes Fury Distribution version: 1.31.0
• furyctl version: 0.31.0

Additional context

This seems to be a recurrent error for Ansible users too.

Note

The node group name that you set in the furyctl.yaml file is also used to determine the nodes role.