Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APP BUG]: gcc build failing on PSFAttributes #2061

Closed
2 tasks done
C0rn3j opened this issue Jan 5, 2025 · 2 comments
Closed
2 tasks done

[APP BUG]: gcc build failing on PSFAttributes #2061

C0rn3j opened this issue Jan 5, 2025 · 2 comments

Comments

@C0rn3j
Copy link
Contributor

C0rn3j commented Jan 5, 2025

Checklist

  • I have searched for a similar issue in this repository and did not find one.
  • I am using an official build obtained from releases or updated one of those builds using its in-app updater.

Describe the Bug

[ 39%] Building CXX object CMakeFiles/shadps4.dir/src/common/error.cpp.o
In file included from /home/c0rn3j/.cache/paru/clone/shadps4-git/src/shadps4/src/emulator.cpp:19:
/home/c0rn3j/.cache/paru/clone/shadps4-git/src/shadps4/src/common/elf_info.h:114:40: error: declaration of ‘const Common::PSFAttributes& Common::ElfInfo::PSFAttributes() const’ changes meaning of ‘PSFAttributes’ [-Wchanges-meaning]
  114 |     [[nodiscard]] const PSFAttributes& PSFAttributes() const {
      |                                        ^~~~~~~~~~~~~
/home/c0rn3j/.cache/paru/clone/shadps4-git/src/shadps4/src/common/elf_info.h:114:25: note: used here to mean ‘union Common::PSFAttributes’
  114 |     [[nodiscard]] const PSFAttributes& PSFAttributes() const {
      |                         ^~~~~~~~~~~~~
/home/c0rn3j/.cache/paru/clone/shadps4-git/src/shadps4/src/common/elf_info.h:20:7: note: declared here
   20 | union PSFAttributes {
      |       ^~~~~~~~~~~~~

#2027 makes sure this is caught in the CI, but until that is merged, this made it through again.

Reproduction Steps

Build on GCC

Expected Behavior

No response

Specify OS Version

Arch Linux

@cromachina
Copy link

Simple patch for this issue on top of 8f33dfe if anyone wants to just get it to compile on their system with GCC:
patch.txt

@C0rn3j
Copy link
Contributor Author

C0rn3j commented Jan 8, 2025

#2089 was merged that fixes this, and #2027 was merged with the CI, this should happen no more :)

@C0rn3j C0rn3j closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants