You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The findUpSync logic finds an unpatched serverless instance due to pnpm's node_modules structure.
Expected behavior
Deploying ... logs should not be printed
Steps to reproduce
pnpm with serverless-patched
Versions
OS/Environment: macos 12.2.1
@sls-next/serverless-patched: ^3.4.0
Checklist
You have reviewed the README and FAQs, which answers several common questions.
You have reviewed our DEBUGGING wiki and have tried your best to include complete information and reproduction steps (including your configuration) as is possible. As there is only one maintainer (who maintains this in his free time) and thus very limited resources, if you have time, please try to debug the issue a bit yourself if possible.
You have first tried using the most recent latest or alpha@sls-next/serverless-componentrelease version, which may have already fixed your issue or implemented the feature you are trying to use. Note that the old serverless-next.js component and the serverless-next.js plugin are deprecated and no longer maintained.
Possible issues to address:
Use the proper patched serverless binary
Don't print Note: running patched serverless binary. inside bin/serverless-patched.ts but add this log line to the patch @serverless+cli+1.5.3.patch itself. It was very confusing to track down this issue because of this. Bonus: detect whether the patch is present.
Upstream this to @serverless/cli
To be honest, the amount of work put into this workaround, it seems upstreaming is the best option unless they are hesitant to accept patches.
The text was updated successfully, but these errors were encountered:
Issue Summary
When using
serverless-patched
doesn't work with pnpm.Actual behavior
Calling
serverless-patched
seems to work as the note is printed. but the Deploying logs are still present:The
findUpSync
logic finds an unpatchedserverless
instance due topnpm
'snode_modules
structure.Expected behavior
Deploying ...
logs should not be printedSteps to reproduce
pnpm
withserverless-patched
Versions
Checklist
latest
oralpha
@sls-next/serverless-component
release version, which may have already fixed your issue or implemented the feature you are trying to use. Note that the oldserverless-next.js
component and theserverless-next.js
plugin are deprecated and no longer maintained.Possible issues to address:
Note: running patched serverless binary.
insidebin/serverless-patched.ts
but add this log line to the patch@serverless+cli+1.5.3.patch
itself. It was very confusing to track down this issue because of this. Bonus: detect whether the patch is present.@serverless/cli
To be honest, the amount of work put into this workaround, it seems upstreaming is the best option unless they are hesitant to accept patches.
The text was updated successfully, but these errors were encountered: