Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any plan to contribute to monaco-languages? #70

Open
zry656565 opened this issue Nov 26, 2019 · 5 comments
Open

Is there any plan to contribute to monaco-languages? #70

zry656565 opened this issue Nov 26, 2019 · 5 comments
Labels
ecosystem enhancement New feature or request help wanted Extra attention is needed

Comments

@zry656565
Copy link

There's no Scala official support in https://github.com/microsoft/monaco-languages . Would you guys contribute to this repo soon?

@nicolasstucki nicolasstucki added the help wanted Extra attention is needed label Dec 6, 2019
@kusmierz
Copy link

kusmierz commented Jun 8, 2020

is it complicated to do it?

@nicolasstucki nicolasstucki added ecosystem enhancement New feature or request labels Jun 26, 2020
@ALANVF
Copy link

ALANVF commented Feb 12, 2021

Couldn't help but mention this, but I already did a while back. It could probably be improved upon (due to a dumb decision made by the person who merged my PR), however I think it's pretty good otherwise

@Jentsch
Copy link
Contributor

Jentsch commented Feb 10, 2025

For who ever want to follow up on this the source is now located at: https://github.com/microsoft/monaco-editor/blob/main/src/basic-languages/scala/scala.ts

I'm however wondering is this issue is still relevant? And is this the right project to adress this issue and not, for example, in the monaco-editor? The current implementation seems to be independend of this project.

@tgodzik
Copy link
Contributor

tgodzik commented Feb 11, 2025

Doesn't look like it's relevant, since the implementation is separate. Though ideally we would reuse the grammar here for the other project 🤔

@Jentsch
Copy link
Contributor

Jentsch commented Feb 11, 2025

The grammars don't look similar. There are some conceptional similarities but the JSON schema looks very different. If there is no automated translation between this two technologies, and I could find any mention in documentation of languages in monaco, I don't see how we could archive that with the grammar we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants