Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bootstrap div styles for exceptions #7

Open
ShaneCurcuru opened this issue May 26, 2017 · 0 comments
Open

Use Bootstrap div styles for exceptions #7

ShaneCurcuru opened this issue May 26, 2017 · 0 comments

Comments

@ShaneCurcuru
Copy link
Contributor

Since many users will be including Bootstrap styles, it would be helpful to include those classes/styles when displaying non-user data from wunderbar, like in HTMLMarkup. _exception

https://github.com/rubys/wunderbar/blob/master/lib/wunderbar/html-methods.rb#L273

Something as simple as:

        if traceback_class
          _div.alert.alert_danger role: 'alert' do
            tag! :pre, text, :class=>traceback_class
          end        
        else
# ... etc.

should be harmless without bootstrap, but will properly put the exception traceback in a semantically appropriate alert box in the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant