Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React router pre-rendering causes a build failure #33

Closed
harrisjose opened this issue Dec 14, 2024 · 1 comment
Closed

React router pre-rendering causes a build failure #33

harrisjose opened this issue Dec 14, 2024 · 1 comment

Comments

@harrisjose
Copy link

x Build failed in 129ms
[react-router] Named export 'renderToReadableStream' not found. The requested module 'react-dom/server' is a CommonJS module, which may not support all module.exports as named exports.

My entry.server.tsx is the standard one from the examples (cloudflare/base). Any ideas on how to resolve this. I found this issue but I'm not sure if its related.

@harrisjose
Copy link
Author

harrisjose commented Dec 15, 2024

The above issue was resolved by importing from 'react-dom/server.browser'. Build still fails but it seems to be an open issue in react-router: remix-run/react-router#12758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant