Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for broken import on future Python 3.10 #78

Closed
HelioGuilherme66 opened this issue Sep 23, 2021 · 11 comments
Closed

Comments

@HelioGuilherme66
Copy link
Member

I was just experimenting the Example, and got the following output:

C:\Users\Helio>python -m robotremoteserver test
C:\Python39\lib\site-packages\robotremoteserver.py:18: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
  from collections import Mapping
Remote server running at http://127.0.0.1:8270.

C:\Users\Helio>python --version
Python 3.9.6
@DanielPenning
Copy link

DanielPenning commented Jan 5, 2022

Can confirm for the current pip release (also for python 3.10).
However, this was already fixed 2 years ago on master (e625c74).
This fix works fine for me.

@pekkaklarck Is it easily possible to publish a release containing the above fix?

@ShemTovYosef
Copy link

ShemTovYosef commented Feb 10, 2022

Hi @pekkaklarck
Since robot framework supports it from 4.1.1, we want to move to python 3.10 but missing this fix in PythonRemoteServer stops us.
Any chance to get it?

With regards,
Yosef

@SePossum
Copy link

SePossum commented Mar 28, 2022

Hi,

I found the same problem today when setting up a new computer with python 3.10.4 and robotframework 5.0:

The following change fixes the problem for me:

In ...\Python\Python310\Lib\site-packages\robotremoteserver.py
change line 18
"""
from collections import Mapping
"""
to
"""
try:
from collections import Mapping
except:
# for Python 3.10
from collections.abc import Mapping
"""

Regards,
Bernd

@oberi01
Copy link

oberi01 commented Aug 18, 2022

Hi @pekkaklarck,
same as Yosef: the broken import stops us from moving to Python310.
Any plans of releasing a fix?
Thanks!
Richard

@Snooz82
Copy link
Member

Snooz82 commented Aug 18, 2022

+1

@UyttenhoveSimon
Copy link

UyttenhoveSimon commented Sep 23, 2022

I concur with the above folks, it would greatly help us if you could push a new release.
Thanks !
Simon

@pekkaklarck
Copy link
Member

This problem has been reported and already fixed in 2020 (#58) but there hasn't been any release after that. A bug fix release with this and other Python compatibility fixes is now planned for next Thursday.

@pekkaklarck
Copy link
Member

Closing this as a duplicate of #58.

@pekkaklarck
Copy link
Member

Already fixed #81 covers similar problem with Python 3.11. Need to think should I create v1.1.1 bug fix release with these fixes already this weekend instead of waiting for next Thursday. We could then possibly have v1.2 with other enhancements later.

@ShemTovYosef
Copy link

Already fixed #81 covers similar problem with Python 3.11. Need to think should I create v1.1.1 bug fix release with these fixes already this weekend instead of waiting for next Thursday. We could then possibly have v1.2 with other enhancements later.

Thank you , great news!
Better to provide 1.1.1 so a new functionality will not affect current projects

@pekkaklarck
Copy link
Member

If we do 1.2 instead of 1.1.1, it will be a small release and should be safe to upgrade to. It would mainly (only?) add get_library_information method (#75) which would speed up Remote library usage considerably especially with bigger libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants