Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discuss moving to JSON schema 2020-12 (from draft-07) #280

Closed
kbroch-rivosinc opened this issue Nov 18, 2024 · 4 comments
Closed

discuss moving to JSON schema 2020-12 (from draft-07) #280

kbroch-rivosinc opened this issue Nov 18, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@kbroch-rivosinc
Copy link
Collaborator

The latest stable json schema is 2020-12: https://json-schema.org/specification
whereas draft-07 is 2 versions behind.

Here's release notes:

@kbroch-rivosinc kbroch-rivosinc added the enhancement New feature or request label Nov 18, 2024
kbroch-rivosinc added a commit that referenced this issue Nov 18, 2024
@dhower-qc
Copy link
Collaborator

Yea, there are a few things out of 2019-09 in particular that would be nice. I picked draft07 because that is the version supported by the YAML extension in VSCode that gives you live feedback.

Is there a feature(s) from 2019/2020 that you are particularly interested in?

@kbroch-rivosinc
Copy link
Collaborator Author

Nothing specific, just looking at the new features in general and figured starting on the latest stable would be better.
I did figure there might be some downstream SW that we wanted that wasn't compatible.

It looks like there's been some movement for that vscode extension:

@dhower-qc
Copy link
Collaborator

Unfortunately, it seems that there is no activity in the past six months on the YAML extension. Since it's unlikely there will be a version bump any time soon, I suggest we close this issue. We can circle back if activity picks back up (there are 15M installs, so there is a chance someone adopts maintenance).

@kbroch-rivosinc
Copy link
Collaborator Author

Agreed. The newer dialects seem overly complicated which I think could lead to slower support.

There was an interesting discussion where someone propose that semver be put into a json schema dialect as a "format" (like date, uri, or email). That was rejected and the suggestion was that "$vocabulary" from the 2019-09 dialect be used but that seems like a more complicated solution than just taking the regex here: https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants