Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DetectorFix: Slack #9

Open
ankushgoel27 opened this issue Dec 9, 2024 · 0 comments
Open

DetectorFix: Slack #9

ankushgoel27 opened this issue Dec 9, 2024 · 0 comments
Labels
area/detectors kind/bug Something isn't working

Comments

@ankushgoel27
Copy link

ankushgoel27 commented Dec 9, 2024

slack bot token regex need to be changed to - "Slack Bot Token": regexp.MustCompile(xoxb\-[0-9]{10,13}[a-zA-Z0-9\-]*) which captures the old format also.

We can also implement the v1/v2 thing if that is what you have in mind but this seems more reasonable to me.

@rgmz rgmz added area/detectors kind/bug Something isn't working labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/detectors kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants