Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email templates: use new theme #499

Open
humitos opened this issue Sep 26, 2024 · 1 comment
Open

Email templates: use new theme #499

humitos opened this issue Sep 26, 2024 · 1 comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@humitos
Copy link
Member

humitos commented Sep 26, 2024

We are sending emails using the old styles. It would be good to refresh them by using the simplicity look and feel from the new dashboard. I think this is the file we need to update: https://github.com/readthedocs/readthedocs.org/blob/f8cbc1310524a91230d80bb4956e3b164911dd3b/readthedocs/templates/core/email/base.html

Here is an example:

Screenshot_2024-09-26_13-41-42

@humitos humitos added the Improvement Minor improvement to code label Sep 26, 2024
@agjohnson
Copy link
Contributor

agjohnson commented Sep 27, 2024

Unfortunately, using our dashboard styles in emails is not possible.

Email styling is a shit show and if you look at that source, it's all tables and inline CSS. This is on purpose as various providers like Gmail especially make styling as hard as possible.

Here is a breakdown of all the things that various providers break:
https://www.campaignmonitor.com/css/

Here's everything Gmail Android breaks for example (it's a lot):
https://www.campaignmonitor.com/css/email-client/gmail-android-app-imap/

I'm not opposed to updating the styles in the email templates but also very much not looking forward to working with these limitations or testing them.

@agjohnson agjohnson added the Needed: design decision A core team decision is required label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

2 participants