Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculating blocks that can be uncrafted/issues with ores #1

Open
Technocality opened this issue Jun 3, 2024 · 3 comments
Open

Calculating blocks that can be uncrafted/issues with ores #1

Technocality opened this issue Jun 3, 2024 · 3 comments

Comments

@Technocality
Copy link

What block(s)/item(s) have an unsatisfactory price?

Blocks of ore

What is the current price of the block(s)/item(s)?

Diamonds are 550.0 individually and 4554.0 as a block

What price(s) were you expecting instead?

Since you can interchange between the two, diamond blocks should be 4,950, otherwise you are loosing 396 just for selling as a block

Is the item craftable?

Yes

Is there anything else you would like to add to your report?

This is a problem for all ore blocks, I think that it doesn't make sense that the value is decreased in block form as you can just craft them back into single form and get a larger amount. In other words they are interchangeable, so the price should. Also, in general I think that the crafting multiplier is a little bit too low as it takes effort to gather all of the materials and craft them just for it to be a good amount less then the raw materials.

@queengooborg
Copy link
Owner

Crafted items are intentionally a reduced price from the cost of the raw materials, and this is primarily to avoid an economy exploit. If the server allowed players to buy items, a player could gain enough to buy the raw materials, craft them easily (put all the ingredients into the crafting table and shift-click), re-sell and earn the profit, then rinse and repeat.

Another way to think about it is that once an item is crafted, it is less valuable because now, it can only be used for one thing, instead of a raw ingredient that can be used for many different things. Truthfully though, the price reduction of crafted items is quite small, between 1% and 9% depending on how many items were used in the crafting recipe (this is done to add some slight variation to the item values).


Now, in regards to blocks of materials like iron, gold and diamond, that is something that is a special case, because the blocks can be turned back into their original materials, so I'd agree with you that their price should be unchanged. Detecting this will be interesting, however, as not all blocks of materials can be "uncrafted" (amethyst, quartz and glowstone).

I'll have to look and see how best to implement this!

@Technocality
Copy link
Author

Also, it does not make sense for diamond ore to be worth less than a diamond

  • It is harder to acquire, requiring silk touch
  • With Fortune III you get an average of 2.2 diamonds per ore
  • 2.2 diamonds is worth 1210, much more than the current worth of 412.5
  • If you average all of the Fortune enchantments out you get 1.65 diamonds or 907.5

This applies to most ores

@Technocality Technocality changed the title Calculating blocks that can be uncrafted Calculating blocks that can be uncrafted/issues with ores Jun 3, 2024
@X00LA
Copy link

X00LA commented Dec 7, 2024

Hi, sorry to butt in, and I've seen that this topic is already a few months old, but I'd like to put my two cents in here.
I'll give you an example from real life, namely iron ore.
A ton of iron ore currently costs around $106.
A ton of raw iron costs around $120.
Ores are always worth less than the end product that is extracted from them, no matter how much you extract from them, because the ore also contains 'waste'.
With iron ore, there is around 30% - 40% 'waste', i.e. rock, sand and other things that cannot be included in the price.
It is therefore logical that ore is always cheaper than the end product extracted from it.
The prices are also always calculated without taking enchantments into account, because not every player has them on their tools. There are also various enchantments that you would have to take into account, but Essentials or any other economy plugins are not complex enough to take all of that into account.
Such an economy would simply be too OP for Minecraft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants