Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EnvironmentVarGuard in tests instead of manually messing with os.environ #128438

Open
WolframAlph opened this issue Jan 3, 2025 · 0 comments
Open

Use EnvironmentVarGuard in tests instead of manually messing with os.environ #128438

WolframAlph opened this issue Jan 3, 2025 · 0 comments
Labels
tests Tests in the Lib/test dir

Comments

@WolframAlph
Copy link
Contributor

WolframAlph commented Jan 3, 2025 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

Some tests manually tweak os.environ. There is new way to do that with EnvironmentVarGuard. Identify all places and update.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs
@WolframAlph WolframAlph added the type-feature A feature request or enhancement label Jan 3, 2025
@bedevere-app bedevere-app bot mentioned this issue Jan 3, 2025
Open
@WolframAlph WolframAlph changed the title Use EnvironmentVarGuard in test_cmd_line instead of manually messing with os.environ Use EnvironmentVarGuard in tests instead of manually messing with os.environ Jan 3, 2025
@picnixz picnixz added tests Tests in the Lib/test dir and removed type-feature A feature request or enhancement labels Jan 3, 2025
This was referenced Jan 4, 2025
Merged
Merged
gaogaotiantian pushed a commit that referenced this issue Jan 11, 2025
@WolframAlph
gh-128438: Add EnvironmentVarGuard for test_pdb.py (#128522)
0946ed2
picnixz pushed a commit that referenced this issue Jan 15, 2025
@WolframAlph
gh-128438: Use EnvironmentVarGuard for test_{builtin,io,locale}.py (
ae7f621 
#128476)

Modifying locale-related environment variables in `Lib/test/test_builtin.py`,
`Lib/test/test_io.py` and `Lib/test/test_locale.py` is now achieved by using
an `EnvironmentVarGuard` context instead of an explicit `try-finally` block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@picnixz @gaogaotiantian @WolframAlph