-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building wheels takes a long time with .tox directories present #13
Comments
coverage.py has no dependencies, so the "also builds dependent wheels" part doesn't into play for me, but I would expect that people using this repo are building wheels for uploading to PyPI, so they don't want dependent wheels either. |
That stinks. Can you think of any downside of just changing https://github.com/pypa/python-manylinux-demo/blob/master/travis/build-wheels.sh#L10 to use |
I changed my own version of this script, and it seems fine (and fast!), but I haven't distributed those wheels yet. I found that the wheels made both ways had identical names and sizes, though the sha1 sums were different, maybe just because of timestamps. |
Sounds good. I'd be happy to merge a PR to that effect, if you think it's warranted. |
In the long run we want to move towards |
I'm forgetting the details of why I had to change directories, but this is how I changed this script in the coverage.py repo: nedbat/coveragepy@f2517c9 The clean step is needed or one build's files will be packaged into the next build. |
Building the manylinux wheels for coverage.py took 1hour 45minutes. Once I removed all my .tox directories, it took 3 minutes.
The problem is that "pip wheel" copies the entire tree somewhere else first. If we use "python setup.py bdist_wheel", it skips that step. If I do that, then even with .tox directories, building wheels takes only 2 minutes.
Here's an IRC exchange about it:
The text was updated successfully, but these errors were encountered: