Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Create PodDisruptionBudget for each prometheus shard #5107

Open
swar8080 opened this issue Jan 1, 2025 · 1 comment
Labels
enhancement New feature or request lifecycle/stale

Comments

@swar8080
Copy link

swar8080 commented Jan 1, 2025

Is your feature request related to a problem ?

When sharding prometheus in the high-availability set-up, at least one prometheus pod per shard should always be running to avoid missing scrapes. PodDisruptionBudgets are helpful here

However, the PodDisruptionBudget created by this chart has label selectors that match on every prometheus pod. So if you're running with two shards each with two replicas for example, then you can't guarantee that only one pod per shard is disrupted at a time

Describe the solution you'd like.

When sharding is enabled, create a PodDisruptionBudget for each shard. The existing operator.prometheus.io/shard label could be used for the label selector

Describe alternatives you've considered.

Creating custom PodDisruptionBudgets instead of relying on this helm chart is always an option but its convenient if this chart handles this instead

Additional context.

I can implement this change

@swar8080 swar8080 added the enhancement New feature or request label Jan 1, 2025
@swar8080 swar8080 changed the title [kube-prometheus-stack] Create PodDisruptionBudget for each shard [kube-prometheus-stack] Create PodDisruptionBudget for each prometheus shard Jan 1, 2025
Copy link

stale bot commented Feb 1, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lifecycle/stale
Projects
None yet
Development

No branches or pull requests

1 participant