From 06daa66fc4ccab790be3753323392234ce9fef91 Mon Sep 17 00:00:00 2001 From: Ben Kochie Date: Thu, 7 Nov 2024 09:39:07 +0000 Subject: [PATCH] Cleanup golangci-lint config (#219) * Remove obsolete go-kit exception. * Remove codespell CI step in favor of misspell plugin. * Enable sloglint plugin. Signed-off-by: SuperQ --- .circleci/config.yml | 11 ----------- .golangci.yml | 3 +-- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 5957289..9fea1ad 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -16,13 +16,6 @@ jobs: - run: make - prometheus/store_artifact: file: bind_exporter - codespell: - docker: - - image: cimg/python:3.11 - steps: - - checkout - - run: pip install codespell - - run: codespell --skip=".git,./vendor,ttar,go.mod,go.sum,*pem" -L uint,packages\',uptodate workflows: version: 2 bind_exporter: @@ -36,10 +29,6 @@ workflows: filters: tags: only: /.*/ - - codespell: - filters: - tags: - only: /.*/ - prometheus/publish_master: context: org-context docker_hub_organization: prometheuscommunity diff --git a/.golangci.yml b/.golangci.yml index faaac13..0715fed 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -3,6 +3,7 @@ linters: enable: - misspell - revive + - sloglint issues: exclude-rules: @@ -15,8 +16,6 @@ linters-settings: exclude-functions: # Used in HTTP handlers, any error is handled by the server itself. - (net/http.ResponseWriter).Write - # Never check for logger errors. - - (github.com/go-kit/log.Logger).Log revive: rules: # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#unused-parameter