Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status #1

Open
gonzus opened this issue Jun 12, 2018 · 8 comments
Open

Status #1

gonzus opened this issue Jun 12, 2018 · 8 comments

Comments

@gonzus
Copy link

gonzus commented Jun 12, 2018

Hello,

I wonder if you intend to update the code to build agains the current version of V8. I am looking into this myself, but have never worked with V8 before, so it will take me some time.

@pmurias
Copy link
Owner

pmurias commented Jun 13, 2018 via email

@micwoj92
Copy link

@gonzus Last 4 versions of this module have been published by @mohawk2 and it seems that the primary repo is now https://github.com/dgl/javascript-v8.
However it is not compatible with current version of v8 (11.x.x), only 7.8 according to changelog.

@dgl Could you please enable issues on your repo?

@dgl
Copy link
Contributor

dgl commented Feb 26, 2023

Not sure why issues on the repo is relevant, metacpan links to https://rt.cpan.org/Public/Dist/Display.html?Name=JavaScript-V8 for issues.

@mohawk2
Copy link

mohawk2 commented Feb 27, 2023

I am happy to accept PRs that enable support for both 7.8 and 11.x.x, but it currently targets 7.8 as that is packaged on Ubuntu.

@gonzus
Copy link
Author

gonzus commented Feb 27, 2023 via email

@mohawk2
Copy link

mohawk2 commented Mar 3, 2023

@gonzus That's a generous gesture, but I'm not sure what ownership you're offering to transfer - are you @pmurias ?

@gonzus
Copy link
Author

gonzus commented Mar 3, 2023

This is hilarious... my mistake. I don't even remember having written that first message in this issue. In fact, I ended up writing my own wrapper (https://github.com/gonzus/JavaScript-V8-XS), and when I saw messages in my Inbox talking about @pmurias 's code, I mistakenly assumed they were about my wrapper. LOL.

TL;DR: please disregard my ramblings. Peace.

@mohawk2
Copy link

mohawk2 commented Mar 3, 2023

@gonzus In that case please close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants