Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple author affiliations and RORs QA #10900

Open
bozana opened this issue Feb 7, 2025 · 8 comments
Open

Multiple author affiliations and RORs QA #10900

bozana opened this issue Feb 7, 2025 · 8 comments
Milestone

Comments

@bozana
Copy link
Collaborator

bozana commented Feb 7, 2025

This is the issue to collect the issues raised at testing and QA for multiple author affiliations and RORs. d
Here are also some cases that could be tested:

  • when I upgrade from an older version to 3.5, all old author affiliations are the same, eventually with RORs (if the mapping was possible)
  • as submitting user (that only have one affiliation that is differently saved from author affiliations), i.e. when the user becomes an author and appears in the contributors list, my affiliation is correctly mapped to the new author affiliations, eventually with ROR
  • as author and editor, when I start typing affiliation name I get a list of ROR names that contains the words I typed in. (Here the ROR API is used and the order is as returned from the ROR API)
  • as author and editor I can add an affiliation name that is not in the ROR repository and provide translations in all form languages i.e. in all possible submission languages. The name in submission locale is required.
  • clicking on add button the affiliation is added to the list
  • as author and editor I can edit the names of the non ROR author affiliations
  • as author and editor I can remove an institution form the list
  • when I save the contributor form, the current author affiliations form the form are correctly saved in the DB table author_affiliations and author_affiliation_settings
  • when the submission locale is changed, and no name in the new locale exists for a non ROR affiliation, the name from the old locale will be copied to the new submission locale.
  • when I read the article, I see all authors affiliations listed on the article view page, in the header as well as in the biography part
  • author affiliations are correctly considered for crossref, datacite, doaj, pubmed, oai_marc, oai_marcxml, oai_rfc1807, google scholar, jats, native import/export, OMP onix,
@bozana bozana added this to the 3.5 Internal milestone Feb 7, 2025
@asmecher
Copy link
Member

asmecher commented Feb 7, 2025

One more to add -- I think we already discussed this with @Devika008 but maybe she can confirm? After a new affiliation is added (either ROR or non-ROR) it's really easy to miss pressing the "Add" button to actually add it to the list. It's possible to misunderstand the "Add" as adding another new row, not completing the one that's just been filled out. Deferring to Devika, but I'd suggest either

  • making sure that the user gets a warning if they don't complete the "Add" part, or
  • just making the "Add" implicit if there's an unfinished row when the form is submitted.

@Devika008
Copy link

Hi @asmecher

What we can do is, when the form is filled and the user starts interacting with other parts of the page or navigates away, we trigger an alert—similar to what Jarda has implemented. This would work like the existing alert that appears when a form is filled but not saved, and the user clicks outside of it.

The pop-up message can say:

"The affiliation has not been added. To save it, please click 'Add' at the end of the row."

You can check out the video demo here! 😊

Screen.Recording.Feb.7.2025.mov

@GaziYucel
Copy link
Contributor

Issue #10906 is fixed in this PR pkp/ui-library#518

@GaziYucel
Copy link
Contributor

GaziYucel commented Feb 8, 2025

Issue #10902 is fixed in this PR pkp/ojs#4649

OPS: pkp/ops#873

OMP: pkp/omp#1837

@GaziYucel
Copy link
Contributor

GaziYucel commented Feb 8, 2025

We also need to check if affiliations are not null for ror migrations.

Saving ror gives an error for language codes 'no_lang_code'. Schema ror.json is changed for this purpose.

Issue #10905 and PR #10912

@GaziYucel
Copy link
Contributor

GaziYucel commented Feb 9, 2025

Some points of issue #10903 are fixed in this PR pkp/ui-library#519

@GaziYucel
Copy link
Contributor

Issue #10904 is addressed in this PR pkp/ui-library#520

@GaziYucel
Copy link
Contributor

Issue #10928 is resolved in PR pkp/ops#874.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants