-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quickstart Guide Fails Because of Missing Redis #11880
Comments
to disable redis usage add If you are using the web-starter module, please add this property as well. Thank you for the detailed explanation and feedback. I will further check this issue. |
Thanks for the hint, adding Taking these changes, the following script seems so start the pinpoint services for me correctly:
My next goal is to execute the quickstart demo. Unfortunately, this doesn't compile:
My first try was to fix the dependencies, but according to the quickstart version, some Java imports needed to be fixed. The PR #11885 fixes the compilation. If I run this using
Unfortunately, I am not a spring expert, do you have a fix for this? |
I've fixed the problem and made some changes, but some outdated APIs will not work. 4eb6a07 |
Thanks, with this update, the example app starts, and using But the only thing I see right now (after clicking around in the application) is the following: Looking at the inspector yields empty graphs and the following error:
(I cannot copy the whole error). I would like to see the traces and spans of my call, i.e., which method was called, when did the method start and when did it end (like Zipkin would do it). According to the FAQ on https://github.com/pinpoint-apm/pinpoint-apm.github.io/blob/main/faq.md, I can also set Could you give me an hint how to also collect the spans (maybe starting Redis)? |
to check span data
you don't need to set inspector page errorThe Inspector page displays metric data (e.g., Heap Usage, CPU Usage). |
Thanks for the hint. Creating the requests and seeing them in the transaction view works, I've set Unfortunately, for some reason, Furthermore, I changed the TestApp like this:
Furthermore, I tried to change the entrypoint using Additionally, I tried to get the internal method calls directly in the HTTP calls by extending the
Still, I do not see any calls to myMethod (but it affects the call time). Is there any way to instrument these simple calls? And regarding the metric display, I tried to add all tables, but I didn't manage to get
I am surprised by this, since the |
I will only answer what I can at the moment. For other matters, I need to try things out. for tracking myMethod() at
|
########################################################### | |
# user defined classes # | |
########################################################### | |
# Specify classes and methods you want to profile here. | |
# Include | |
# It is designed for plugin debugging. | |
# Many classes of methods can be tracked. | |
# Tracks all public methods of the target class. | |
# Needs to be a comma separated list of fully qualified class names, or fully qualified package names with wild card class. | |
profiler.include= | |
# Ex: foo.bar.MyClass, foo.baz.* | |
# Entry point | |
# Tracks libraries that pinpoint plugin does not support. | |
# The target method serves as an entry point for tracking. | |
# Excluding the abstract and native method. | |
# Needs to be a comma separated list of fully qualified method names. Wild card not supported. | |
profiler.entrypoint= | |
# Ex: foo.bar.MyClass.myMethod, foo.bar.MyClass.anotherMethod |
creating inspectorStatApp pinot table
use /tables
instead of /schemas
Thanks for the hints. I tried setting
and
but both (and their combinations) didn't make profiling work. Additionally, I searched the pinpoint code base for the solution. I found this: https://github.com/pinpoint-apm/pinpoint-plugin-sample/blob/master/plugins/sample/src/main/java/com/navercorp/pinpoint/plugin/sample/_02_Injecting_Custom_Interceptor/Sample_02_Inject_Custom_Interceptor.java which in turn recommends to use https://github.com/pinpoint-apm/pinpoint/blob/master/agent-module/bootstraps/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/SpanEventSimpleAroundInterceptorForPlugin.java#L30 for that purpose. Unfortunately, I couldn't find any subclass that does pure tracing of methods, all of them are suited towards some framework. Additionally, I tried starting redis (using The logs of my run are here: And I see the Do you have another idea, maybe also where to search in the code? Thanks also for the hint regarding the |
After extensive reading of the code, I found the issue: Line 47 in b81be79
I'll create a PR to document this. |
Prerequisites
What version of pinpoint are you using?
v3.0.1
Describe the bug
I am just getting started and tried to execute the quickstart guide (https://pinpoint-apm.gitbook.io/pinpoint/getting-started/quickstart). This doesn't work, the collector doesn't start and seems to require redis (and I didn't find any documentation for this). Also, the installation guide (https://pinpoint-apm.gitbook.io/pinpoint/getting-started/installation#3-pinpoint-collector) didn't help, always the collector is shutting down.
What did you do to trigger the bug?
Steps to reproduce, for example:
Afterwards, I executed
./multi-table.sh 0 1 http://localhost:9000
in a different terminal, where I changed the REALTIME template to 1 replica (https://github.com/kieker-monitoring/moobench/blob/f4b14fbacf7416465730701dd626065d0f3577d1/frameworks/pinpoint-java/scripts/template_REALTIME.json#L8) and the port to Kafkas default port 9092 (https://github.com/kieker-monitoring/moobench/blob/f4b14fbacf7416465730701dd626065d0f3577d1/frameworks/pinpoint-java/scripts/template_REALTIME.json#L33) -- it would also be nice if this was specified in the quickstart guide in a way the user doesn't have to fiddle with it (so it would be possible to specify that Kafka listens to a different port, or to change the port in the template).4. Start the collector:
wget https://repo1.maven.org/maven2/com/navercorp/pinpoint/pinpoint-collector-starter/3.0.1/pinpoint-collector-starter-3.0.1-exec.jar
This results in
It seems like for some reason, no connection to redis can be started - which makes sense, since I didn't start Redis and the quickstart guide doesn't specify to do so. Since the collector stops, I think starting the web started and the agent doesn't make sense.
My guess would be that there is another configuration needed, that potentially disables Redis usage, or that Redis should be started and configured - but in any case, this needs to be changed in the quickstart and installation guide.
Expected behavior
I expect the quickstart demo to just show some spans pinpoint gathered.
Logs
The full log is here: collector-start.txt
The text was updated successfully, but these errors were encountered: