Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAFE wallet not able to sign transactions #426

Open
ebma opened this issue Jan 28, 2025 · 2 comments
Open

SAFE wallet not able to sign transactions #426

ebma opened this issue Jan 28, 2025 · 2 comments
Assignees
Labels
type:bug Something isn't working

Comments

@ebma
Copy link
Member

ebma commented Jan 28, 2025

Context

It seems like signing transactions with https://app.safe.global/apps is currently not possible. The flow was as follows:

  • Connect to SAFE with WalletConnect
  • Perform all steps until coming back from anchor page
  • Wait for signing request to approve transfer
  • Sign the approve transfer in SAFE ✅
  • Go back to Vortex
  • See vortex switching from 'Waiting for signature 1/2' to 'Waiting for signature 2/2'
  • Wait a few seconds and the text will switch back from 'Waiting for signature 2/2' to 'Waiting for signature 1/2'
  • Go back to SAFE and see the request to approve the transfer again
  • This happens again and again and the user is always asked to approve the transfer but never to execute it

The account where this happened is: 0xae82321664334C23E2E516192F0A43B175B9214b on Polygon

TODO

Check why Vortex does not recognize the successful approve transaction and keeps requesting a signature for that.

@ebma ebma self-assigned this Jan 28, 2025
@ebma ebma linked a pull request Jan 28, 2025 that will close this issue
@pendulum-chain pendulum-chain deleted a comment Jan 28, 2025
@ebma ebma added the type:bug Something isn't working label Jan 28, 2025
@Sharqiewicz
Copy link
Contributor

👀

@Sharqiewicz
Copy link
Contributor

Sharqiewicz commented Feb 15, 2025

After noticing a recurring issue across multiple projects and discussions:

I've created a focused solution: wagmi-eip-4337, a lightweight library that bridges the gap between wagmi and Account Abstraction wallets. https://www.npmjs.com/package/wagmi-eip-4337

The library currently addresses the most pressing need for us: providing a replacement for wagmi's waitForTransactionReceipt that properly handles Safe Wallet transactions. While the name suggests broader EIP-4337 support, we're starting only with Safe Wallet as it's the most commonly reported issue.

@ebma If you think library is too much, I can add the relevant functions under the src/helpers/safe-wallet/ directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@ebma @Sharqiewicz and others