Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Error Messages in Preview Modal & Section Input Handling #140

Open
5 tasks
bhumulanandinireddy opened this issue Feb 6, 2025 · 1 comment
Open
5 tasks
Assignees
Labels
good first issue Good for newcomers

Comments

@bhumulanandinireddy
Copy link
Collaborator

Issue Description

  1. Preview Modal Behavior:

    • The preview modal does not display API error messages when a failure occurs, making it difficult for users to understand errors.
    • The modal does not close when pressing the Escape key, impacting usability.
  2. Section Input Handling:

    • Currently, the system processes section numbers correctly only when entered sequentially (e.g., 1,2,3,4,5).
    • However, it should also support non-sequential inputs (e.g., 1,3,5) and return the correct results.
    • When users enter a range format (e.g., 1-5), the system should correctly process it as 1,2,3,4,5 instead of failing or misinterpreting input.

Current Status

  • The preview modal does not close when the Escape key is pressed.
  • API error messages are not displayed in the preview modal when failures occur.
  • The system only supports sequential section input (e.g., 1,2,3,4,5) but fails to handle non-sequential input (e.g., 1,3,5).
  • The range format (1-5) is not processed correctly to extract sections 1,2,3,4,5.

Acceptance Criteria

  • For Preview Modal:

    • Pressing the Escape key should close the preview modal.
    • If an API failure occurs, the error message returned by the API should be displayed clearly in the modal.
  • For Section Input Handling:

    • The system should allow non-sequential section numbers (e.g., 1,3,5) and extract data correctly.
    • Users entering a range format (e.g., 1-5) should get results for 1,2,3,4,5 without needing to enter them individually.
    • The existing sequential input functionality should remain unaffected.
@bhumulanandinireddy bhumulanandinireddy added the good first issue Good for newcomers label Feb 6, 2025
@chetan102
Copy link

Hey @bhumulanandinireddy I'd like to work on this issue. Can u assign it to me.

@suprajamannava17 suprajamannava17 self-assigned this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants