Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkcellTask ID should be unique, and not based on the work order step ID #63

Open
aaronchongth opened this issue Jan 23, 2025 · 1 comment
Assignees

Comments

@aaronchongth
Copy link
Collaborator

As discussed here, when dealing with parallel work orders, the ID in WorkcellTask is using the step ID from the work order, which easily conflicts with other work orders.

Suggested #42 (comment), we can use a combination of the work order ID and the step ID to produce a unique workcell task ID

@Yadunund
Copy link
Member

After some thought, I think it would be good to

  • update the WorkcellTask msg to include a string work_order_id field and rename the existing id to task_id.
  • Similarly also add a string work_order_id field to the WorkcellState msg which already includes a task_id field.
  • Also update nexus_capabilities/Task to include both work_order_id and task_id. Should we also rename this to WorkcellTask?
  • Update system orchestrator implementation to fill work_order_id in the WorkcellTask using the WorkOrder.id submitted to the system orchestrator. Also update WorkcellState.
  • Update workcell orchestrator to keep track of which work_order id is being processed and update the WorkcellState publishing to reflect this.

@aaronchongth aaronchongth self-assigned this Feb 3, 2025
aaronchongth added a commit that referenced this issue Feb 3, 2025
Signed-off-by: Aaron Chong <[email protected]>
aaronchongth added a commit that referenced this issue Feb 12, 2025
Signed-off-by: Aaron Chong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants