Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPC approval of tiny Charter change for Node.js #1399

Closed
mcollina opened this issue Dec 4, 2024 · 6 comments
Closed

CPC approval of tiny Charter change for Node.js #1399

mcollina opened this issue Dec 4, 2024 · 6 comments
Labels
cross-project-council-agenda

Comments

@mcollina
Copy link
Member

mcollina commented Dec 4, 2024

Please take a look: nodejs/TSC#1650.
This was referenced Dec 9, 2024
Closed
Open
@mhdawson
Copy link
Member

LGTM

@mhdawson mhdawson mentioned this issue Jan 6, 2025
Open
@tobie
Copy link
Contributor

tobie commented Jan 7, 2025

LGTM

@ljharb
Copy link
Member

ljharb commented Jan 7, 2025

LGTM

@ctcpip
Copy link
Member

ctcpip commented Jan 7, 2025

looks good for the most part, but I added a comment on the PR for consistency/clarity

@joesepi
Copy link
Member

joesepi commented Jan 7, 2025

LGTM. @ctcpip comment would be good to address though. ✌️

@mhdawson mhdawson mentioned this issue Jan 20, 2025
Open
@tobie
Copy link
Contributor

tobie commented Jan 21, 2025

CPC Call: this was approved.

@tobie tobie closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cross-project-council-agenda
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tobie @ljharb @mcollina @joesepi @mhdawson @ctcpip