Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6NextHdrTest(saiacl module) needs modification as per SAI Standard #2135

Open
kandancs opened this issue Jan 27, 2025 · 2 comments
Open

Comments

@kandancs
Copy link

IPv6NextHdrTest(saiacl module) needs modification as per SAI Standard.

in IPv6NextHdrTest(saiacl) while configuring acl_action_data_t enable flag is missing. But as per SAI Header/standard sai_action paramer valid only when enable flag set to TRUE.

SAI Testcase link: https://github.com/opencomputeproject/SAI/blob/master/ptf/saiacl.py#L4799C36-L4799C51

673 typedef struct _sai_acl_action_data_t
674 {
675 /**
676 * @brief Action enable/disable
677 /
678 bool enable;
679
680 /
*
681 * @brief Action parameter
682 *
683 * @passparam meta
684 *** @validonly enable == true**
685 */
686 sai_acl_action_parameter_t parameter;
687
688 } sai_acl_action_data_t;

SAI Header link: https://github.com/opencomputeproject/SAI/blob/master/inc/saitypes.h#L691

@kcudnik
Copy link
Collaborator

kcudnik commented Jan 27, 2025

can you make an PR to update that ?

@kandancs
Copy link
Author

Sure. I will create the PR to update this..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants