Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubygems post-install notice frequency #1786

Open
Greg-Myers-SB opened this issue Jan 2, 2025 · 3 comments
Open

Rubygems post-install notice frequency #1786

Greg-Myers-SB opened this issue Jan 2, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@Greg-Myers-SB
Copy link

Greg-Myers-SB commented Jan 2, 2025

Description of the bug

Each individual gem in package gives the same ruby and rails notice even though it is not contextually relevant to someone using Ruby 3.3 and Rails 8.

I'd expect one or zero post-install notices if it's not relevant to my install.

Post-install message from opentelemetry-helpers-mysql:
Ruby 3.0 has reached EoL 2024-04-23. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Ruby 3.0 after 2025-01-15. Please upgrade to Ruby 3.1 or higher to continue receiving updates.

Rails 6.1 has reached EoL 2024-10-01. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Rails 6.1 after 2025-01-15. Please upgrade to Rails 7.0 or higher to continue receiving updates.
Post-install message from opentelemetry-helpers-sql-obfuscation:
Ruby 3.0 has reached EoL 2024-04-23. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Ruby 3.0 after 2025-01-15. Please upgrade to Ruby 3.1 or higher to continue receiving updates.

Rails 6.1 has reached EoL 2024-10-01. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Rails 6.1 after 2025-01-15. Please upgrade to Rails 7.0 or higher to continue receiving updates.
Post-install message from opentelemetry-instrumentation-rails:
Ruby 3.0 has reached EoL 2024-04-23. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Ruby 3.0 after 2025-01-15. Please upgrade to Ruby 3.1 or higher to continue receiving updates.

Rails 6.1 has reached EoL 2024-10-01. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Rails 6.1 after 2025-01-15. Please upgrade to Rails 7.0 or higher to continue receiving updates.
Post-install message from opentelemetry-instrumentation-all:
Ruby 3.0 has reached EoL 2024-04-23. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Ruby 3.0 after 2025-01-15. Please upgrade to Ruby 3.1 or higher to continue receiving updates.

Rails 6.1 has reached EoL 2024-10-01. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Rails 6.1 after 2025-01-15. Please upgrade to Rails 7.0 or higher to continue receiving updates.
Post-install message from opentelemetry-processor-baggage:
Ruby 3.0 has reached EoL 2024-04-23. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Ruby 3.0 after 2025-01-15. Please upgrade to Ruby 3.1 or higher to continue receiving updates.

Rails 6.1 has reached EoL 2024-10-01. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Rails 6.1 after 2025-01-15. Please upgrade to Rails 7.0 or higher to continue receiving updates.
Post-install message from opentelemetry-resource-detector-container:
Ruby 3.0 has reached EoL 2024-04-23. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Ruby 3.0 after 2025-01-15. Please upgrade to Ruby 3.1 or higher to continue receiving updates.

Rails 6.1 has reached EoL 2024-10-01. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Rails 6.1 after 2025-01-15. Please upgrade to Rails 7.0 or higher to continue receiving updates.

Share details about your runtime

Operating system details: MacOS Sonoma 14.7.1 (23H222)
RUBY_ENGINE: "ruby"
RUBY_VERSION: "3.3.6"
RUBY_DESCRIPTION: "ruby 3.3.6 (2024-11-05 revision 75015d4c1f) [arm64-darwin23]"

Share a simplified reproduction if possible

require 'bundler/inline'

gemfile(true) do
  source 'https://rubygems.org'

  gem 'opentelemetry-instrumentation-all'
end
@Greg-Myers-SB Greg-Myers-SB added the bug Something isn't working label Jan 2, 2025
@arielvalentin
Copy link
Contributor

The post install messages are intentional and emitted for each gem that instruments Rails. Users may selectively install instrumentation specific gems and we want to make them aware that this change will be coming soon.

Since you are using the "all" it is installing transitive dependencies for Rails instrumentations, even though you aren't activating them or using them in your application.

These messages will stop being emitted once we drop compatibility on 01-15-2025

@Greg-Myers-SB
Copy link
Author

It's good to know it's temporary and thank you for it in general.
More a curiosity, is it possible to prevent it being emitted if you're already on a new ruby or rails?
Happy for this to be closed as it's temporary.

@arielvalentin
Copy link
Contributor

AFAIK Post install messages don't support checks for transitive dependencies.

@simi do you or any RubyGems maintainers have any tips for us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants