Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[operator] Setting multiple feature gates causes operator panic #1481

Closed
swiatekm opened this issue Jan 2, 2025 · 1 comment · Fixed by #1490
Closed

[operator] Setting multiple feature gates causes operator panic #1481

swiatekm opened this issue Jan 2, 2025 · 1 comment · Fixed by #1490
Labels
bug Something isn't working chart:operator Issue related to opentelemetry-operator helm chart

Comments

@swiatekm
Copy link
Contributor

swiatekm commented Jan 2, 2025

When we set multiple feature gates using featureGatesMap, we get a malformed command line argument for the operator, leading to a panic.

Using the following values file:

manager:
  featureGatesMap:
    operator.targetallocator.mtls: false
    operator.collector.targetallocatorcr: false
    operator.sidecarcontainers.native: true
    operator.observability.prometheus: false
    operator.golang.flags: true
    operator.collector.default.config: false

results in the operator getting the following command line argument:

--feature-gates=,,operator.golang.flags,,operator.sidecarcontainers.native,

This is an invalid value, and causes the operator to crash. At a glance, this is caused by the fact that we add a comma to the feature gate string even if the value in the map is false.

Originally reported in open-telemetry/opentelemetry-operator#3559.

@TylerHelmuth
Copy link
Member

Related #1463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chart:operator Issue related to opentelemetry-operator helm chart
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants