Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Remove Explicit Dependency on System.Text.Json in OpenTelemetry.Exporter.OneCollector on net8.0 #2459

Open
keegan-caruso opened this issue Jan 9, 2025 · 1 comment
Labels
bug Something isn't working comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector

Comments

@keegan-caruso
Copy link

Component

OpenTelemetry.Exporter.OneCollector

Package Version

Package Name Version
OpenTelemetry.Exporter.OneCollector 1.10.0

Runtime Version

net8.0

Description

On net8.0 and above, an explicit reference to System.Text.Json is not needed. It is included in the Framework. Removing this reference reduces explicit transitive dependencies.

Steps to Reproduce

Include OpenTelemetry.Exporter.OneCollector in a project using net8.0

Expected Result

OpenTelemetry.Exporter.OneCollector uses STJ from the framework and doesn't use an explicit dependency.

Actual Result

OpenTelemetry.Exporter.OneCollector uses STJ from an explicit dependency.

Additional Context

I can submit a fix if this is accepted.

@keegan-caruso keegan-caruso added the bug Something isn't working label Jan 9, 2025
@github-actions github-actions bot added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Tagging component owner(s).

@CodeBlanch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector
Projects
None yet
Development

No branches or pull requests

1 participant