Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image upload test to chat tests #2474

Open
taoeffect opened this issue Dec 18, 2024 · 0 comments
Open

Add image upload test to chat tests #2474

taoeffect opened this issue Dec 18, 2024 · 0 comments
Assignees
@SebinSong
Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Kind:Test

Comments

@taoeffect
Copy link
Member

Problem

We didn't notice that image upload broke in the SW PR, only later when @SebinSong sent in #2453 did we notice.

If we had tests we would haven noticed earlier.

Solution

  • Add 1 test to the chat tests to verify that uploading an image works ok
  • Make that test upload the image, and also open and view it (and then close the viewer)
@taoeffect taoeffect added Kind:Enhancement Improvements, new features, performance upgrades, etc. App:Frontend Kind:Test labels Dec 18, 2024
@taoeffect taoeffect changed the title Add image upload tests to chat tests Add image upload test to chat tests Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebinSong SebinSong

Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Kind:Test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taoeffect @SebinSong