Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoDaddy DNS support #111

Open
InteXX opened this issue Jul 29, 2020 · 8 comments
Open

GoDaddy DNS support #111

InteXX opened this issue Jul 29, 2020 · 8 comments

Comments

@InteXX
Copy link
Contributor

InteXX commented Jul 29, 2020

Could this be a way to support GoDaddy DNS?

It gets a bit tricky due to GoDaddy's lack of a delete API, but I believe that can be accommodated.

@InteXX InteXX changed the title GoDaddy DNS Support GoDaddy DNS support Jul 29, 2020
@ohadschn
Copy link
Owner

I'm assuming you mean support for the DNS challenge when your DNS provider is GoDaddy.

I'm not using certbot, but it seems the underlying library I'm using does have GoDaddy support (GoDaddyDnsProvider): sjkp/letsencrypt-azure#2 - I see you spotted that issue as well.

So it should be possible, but I don't have any concrete plans to implement it any time soon...

@InteXX
Copy link
Contributor Author

InteXX commented Jul 30, 2020

I don't have any concrete plans to implement it any time soon

I understand.

The solution provided in that issue seems to require a rebuild; it'd be nice to be able to effect a change at runtime, thereby permitting use of the official codebase.

@InteXX InteXX closed this as completed Jul 30, 2020
@ohadschn
Copy link
Owner

ohadschn commented Jul 30, 2020

I'm pretty sure it can be implemented without requiring a rebuild - we should be able to use GoDaddyDnsProvider instead of AzureDnsProvider depending on configuration.

One of the reasons I don't have plans to add GoDaddy DNS though is that I don't have GoDaddy DNS to test it. But if someone were to submit a PR that could work :)

I'm reopening this because it's definitely a legitimate feature request...

@ohadschn ohadschn reopened this Jul 30, 2020
@InteXX
Copy link
Contributor Author

InteXX commented Jul 30, 2020

I'm not at all handy with C#. Otherwise, I'd consider giving it a run.

Testing suggestion: You could register a test domain at GD and point its zone to your Azure stuff. You'd be out twenty bux, though, so that may not be desirable. (Maybe you've already got a spare that you're not using that you could transfer over.)

@InteXX
Copy link
Contributor Author

InteXX commented Oct 4, 2020

Follow-up: If you decide to look into this at some point, I might be able to help by retargeting one (or more) of my parked domains for your needs.

I suppose I could even add you as a DNS admin.

@ohadschn
Copy link
Owner

ohadschn commented Oct 4, 2020

I admit this will be a low priority, but sure if you make me an admin it might speed things up when relevant...

@InteXX
Copy link
Contributor Author

InteXX commented Oct 4, 2020

Perfect. Just let me know, should ever the time come.

@lpperras
Copy link
Contributor

Also needed it for our need so created a PR for it.
#120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants