Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone a specific version notebook #172

Closed
rakeshpatri opened this issue Sep 11, 2019 · 2 comments
Closed

clone a specific version notebook #172

rakeshpatri opened this issue Sep 11, 2019 · 2 comments

Comments

@rakeshpatri
Copy link

I dont find a way to specify versionId from s3 to the clone API, so that i can fetch a specific versioned notebook.
Let me know if there is way to do this in current implementation.

@mpacer
Copy link
Member

mpacer commented Nov 25, 2019

There is no way currently but it is planned to support this.

One of the barriers has been in testing this. We use minio for our integration test, and it does not support versioned buckets and so we may need to either only unit test this functionality or switch to actually using S3 for our integration tests (which introduces its own set of complexities).

@mpacer
Copy link
Member

mpacer commented Dec 10, 2019

@rakeshpatri This is now supported as of 2.5.1, see #176 for the implementation details and https://bookstore.readthedocs.io/en/latest/changelog.html#id3 (version 2.5.1 for the details on how to use it).

Feel free to comment on the issue or create a new one if you have remaining issues, but I'm going to close this since it has been addressed.

@mpacer mpacer closed this as completed Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants