Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential __setup_ui refactor to improve modularity/subclassibility #21

Open
KenyonPrater opened this issue Nov 5, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@KenyonPrater
Copy link

This is a bit subjective, but this issue I created is only a github issue (rather than just something I'd implement my own logic for) because __setup_ui is a big function without any good ways for a subclass to hook into it. This issue is the sort that could also potentially be handled by exposing functions for composition/inheritance.

While it seems like an undertaking, it could potentially be sliced up into smaller functions, so that it's easier for users to make tweaks to the toast widgets.

That said, I do understand the value of a nice clean API that does exactly what you want it to do and doesn't expect the user to go mucking around in its guts causing a mess, so I understand if this is bad design in your view!

@niklashenning niklashenning added the enhancement New feature or request label Nov 6, 2024
@niklashenning
Copy link
Owner

Yeah, I agree with you. Refactoring this method has been on my list for a while now as it's way too big and not clean / intuitive at all. I've been putting this off, but it would be very beneficial for the library, so I think it needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants