Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim.validate is deprecated. Feature will be removed in Nvim 1.0 #3583

Closed
Mte90 opened this issue Jan 23, 2025 · 2 comments · Fixed by #3584
Closed

vim.validate is deprecated. Feature will be removed in Nvim 1.0 #3583

Mte90 opened this issue Jan 23, 2025 · 2 comments · Fixed by #3584
Labels
bug Something isn't working

Comments

@Mte90
Copy link

Mte90 commented Jan 23, 2025

Description

- use vim.validate(name, value, validator, optional_or_msg) instead.
- stack traceback:
        /home/mte90/.vim/plugged/nvim-lspconfig/lua/lspconfig/configs.lua:37
        /home/mte90/.vim/plugged/nvim-lspconfig/lua/lspconfig.lua:89
        /home/mte90/.config/nvim/lua/plugin/lsp.lua:57
        [C]:-1
        /home/mte90/.config/nvim/lua/plugins.lua:136
        [C]:-1
        lua:4
    - stack traceback:
        /home/mte90/.vim/plugged/nvim-lspconfig/lua/lspconfig/configs.lua:77
        /home/mte90/.config/nvim/lua/plugin/lsp.lua:57
        [C]:-1
        /home/mte90/.config/nvim/lua/plugins.lua:136
        [C]:-1
        lua:4
    - stack traceback:
        /home/mte90/.vim/plugged/nvim-lspconfig/lua/lspconfig/configs.lua:37
        /home/mte90/.vim/plugged/nvim-lspconfig/lua/lspconfig.lua:89
        /home/mte90/.config/nvim/lua/plugin/lsp.lua:80
        [C]:-1
        /home/mte90/.config/nvim/lua/plugins.lua:136
        [C]:-1
        lua:4
@Mte90 Mte90 added the bug Something isn't working label Jan 23, 2025
@dundargoc
Copy link
Member

dundargoc commented Jan 23, 2025 •
edited
Loading

Right, this is the output from :checkhealth vim.deprecated. We decided to not remove the deprecated vim.validate calls in #3517 (comment) since that file was going to be removed in the future anyway, but we hadn't taken the vim.deprecated output into consideration.

@Mte90
Copy link
Author

Mte90 commented Jan 23, 2025

I just spotted because the majority of my checkhealth is generated by this deprecation as I have various LSP plugins.

dundargoc added a commit to dundargoc/nvim-lspconfig that referenced this issue Jan 23, 2025
@dundargoc
fix: remove validation from configs.lua
511d40f 
This is because using the old syntax for vim.validate causes
`:checkhealth vim.deprecated` to be flooded with deprecated messages.

It would also be possible to do a version check and use the newer syntax
for vim.validate, but since configs.lua will be replaced by
vim.lsp.config in the future there is little need to future-proof it.

Closes neovim#3583.
@dundargoc dundargoc mentioned this issue Jan 23, 2025
Merged
dundargoc added a commit to dundargoc/nvim-lspconfig that referenced this issue Jan 23, 2025
@dundargoc
fix: remove validation from configs.lua
0729fac 
This is because using the old syntax for vim.validate causes
`:checkhealth vim.deprecated` to be flooded with deprecated messages.

It would also be possible to do a version check and use the newer syntax
for vim.validate, but since configs.lua will be replaced by
vim.lsp.config in the future there is little need to future-proof it.

Closes neovim#3583.
dundargoc added a commit that referenced this issue Jan 23, 2025
@dundargoc
fix: remove validation from configs.lua
b4d65bc 
This is because using the old syntax for vim.validate causes
`:checkhealth vim.deprecated` to be flooded with deprecated messages.

It would also be possible to do a version check and use the newer syntax
for vim.validate, but since configs.lua will be replaced by
vim.lsp.config in the future there is little need to future-proof it.

Closes #3583.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove validation from configs.lua dundargoc/nvim-lspconfig
2 participants
@Mte90 @dundargoc