Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alignment input #306

Open
rneher opened this issue Dec 30, 2024 · 1 comment
Open

alignment input #306

rneher opened this issue Dec 30, 2024 · 1 comment
Labels

Comments

@rneher
Copy link
Member

rneher commented Dec 30, 2024

The rust implementation currently follows a pattern similar to nextclade where the sequence input is read from positional arguments or stdin, while tree and metadata are keyword arguments.

However, the nature of the sequences is different here from what it is in nextclade:
Sequences are not independent entities that can be processed from one or multiple files. Instead, there is a mapping from leaves of the tree to sequences in the alignment (it is ok if some sequences are missing). Sequences also have to be aligned, so it is reasonable to expect that all sequences are in one file. If there are multiple files, it would be natural to treat these as different partitions.

One could imagine flags like --nt-aligments partition1.fasta partition2.fasta and --aa-alignments HA.fasta NA.fasta PB2.fasta.

@rneher rneher added the rust label Dec 30, 2024
@rneher
Copy link
Member Author

rneher commented Dec 30, 2024

We anyway had on the ToDo a rethink/abstraction of the partitions such that we can flexibly handle partitions with different alphabets and different types. Probably better to tackle this after that re-org.

The primary partition types I see are sequences with different alphabets (nuc, aa, maybe binary at some point) and single discrete traits with arbitrary alphabet. The former can be either sparse or dense.

For more complex specifications (like different partitions for different parts of a sequence, 1st, 2nd, 3rd codon position etc, we might need config files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant