Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note about adding the code to annotations #7

Open
jairwin06 opened this issue Feb 19, 2014 · 2 comments
Open

Note about adding the code to annotations #7

jairwin06 opened this issue Feb 19, 2014 · 2 comments

Comments

@jairwin06
Copy link
Contributor

This pertains to video 3.1 only, so far.

As a rule, if the code was short I added it directly into the window. If longer/more complex (includes classes), the annotation refers to the direct github link. If you prefer a different method, let me know.

@shiffman
Copy link
Member

This makes sense, although I think rather than linking to github web site we should use the API solution that Scott created that displays the code nicely in the video page, i.e. instead of:

<a href="https://github.com/shiffman/The-Nature-of-Code-Examples/tree/master/chp3_oscillation/NOC_3_02_forces_angular_motion">See the code</a> .

It would be:

<a href="https://api.github.com/repos/shiffman/The-Nature-of-Code-Examples/contents/chp3_oscillation/NOC_3_02_forces_angular_motion" data-displaycode="true">See the code</a> .

You can reference this discussion for more: shiffman/icm.shiffman.net#5

I might err on the side of doing this always except for very short snippets.

@jairwin06
Copy link
Contributor Author

Aha. Fixed 3.1 and will do so for the others moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants