Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Support QR code on deploy preview to ease mobile test #261

Open
oliviertassinari opened this issue Jan 13, 2025 · 1 comment · May be fixed by mui/material-ui#45078
Open

[docs-infra] Support QR code on deploy preview to ease mobile test #261

oliviertassinari opened this issue Jan 13, 2025 · 1 comment · May be fixed by mui/material-ui#45078
Labels
new feature New feature or request scope: docs-infra Specific to the docs-infra product status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 13, 2025 •
edited
Loading

Summary

See mui/base-ui#1307 (comment) for context.

We should be able to remove the Netlify notification and collapse the code comments into a single Danger update. This would allow to:

Vercel doesn't support QR code, so that would help even more if we migrate docs hosting there.
@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer scope: docs-infra Specific to the docs-infra product labels Jan 13, 2025
@oliviertassinari oliviertassinari mentioned this issue Jan 13, 2025
Merged
@oliviertassinari oliviertassinari added the new feature New feature or request label Jan 13, 2025
@Janpot Janpot linked a pull request Jan 21, 2025 that will close this issue
Draft
@Janpot
Copy link
Member

Janpot commented Jan 22, 2025

Quickly slapped something together in mui/material-ui#45078

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature New feature or request scope: docs-infra Specific to the docs-infra product status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[code-infra] Qr code deploy urls Janpot/material-ui
2 participants
@Janpot @oliviertassinari