[joy-ui][templates] Confusing import of feather-icons

[mdesantis]

Hello! While messing around with Joy UI's Order Dashboard template, I came across this puzzling piece of code:

material-ui/docs/data/joy/getting-started/templates/order-dashboard/App.tsx

Lines 24 to 33 in d2b0415

	const status = useScript('https://unpkg.com/feather-icons');
	useEnhancedEffect(() => {
	// Feather icon setup: https://github.com/feathericons/feather#4-replace
	// @ts-ignore
	if (typeof feather !== 'undefined') {
	// @ts-ignore
	feather.replace();
	}
	}, [status]);

I tried to figure out what it is for, but without luck. It imports feather-icons and then calls replace, that by docs should find all [data-feather] occurrences and inject their icons, but I have no evidence of this happening somewhere in the template; is it a typo, or some obscure magic I'm too noob to understand? 🤯

[zanivan]

Hey @mdesantis good catch! This looks like some outdated code from the previous version of this template, where we've used feather-icons. I went ahead and opened a PR (#40095) to remove these, since we're using only the rounded Material Icons now.

[siriwatknp]

@mdesantis Thanks for pointing that out. That snippet is specific to our docs setup. I'd recommend to check out https://github.com/feathericons/react-feather for your project if you want to use feather icons.