Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfm-scrobble v1.0 #38

Open
dmfutcher opened this issue Nov 1, 2019 · 1 comment
Open

rustfm-scrobble v1.0 #38

dmfutcher opened this issue Nov 1, 2019 · 1 comment

Comments

@dmfutcher
Copy link

Hey @mrmekon, I'm the author of rustfm-scrobble and can see you use it here. Just wanted to give you a heads-up I released version 1.0 of the library. A lot of fixes & updates so it's likely worth updating. Went to submit a PR myself & saw that you're using a forked version; would be happy to talk about putting your use-case behind a feature flag or something so you can use the library without maintaining a fork. Give me a shout if you have any questions, happy to help.

@mrmekon
Copy link
Owner

mrmekon commented Nov 3, 2019

Thanks for the notice, @bobbo. I'll try to bump my fork sometime soon(ish).

I doubt you would want to incorporate my changes upstream. Though this is something I run into a lot with Rust, so it is an interesting thing to keep in mind. rustfm-scrobble uses reqwest for its HTTP client, while connectr uses curl. reqwest is quite large and takes a long time to build, so my fork hacks up rustfm-scrobble to also use curl. This is something I keep running into, where any non-trivial Rust binary ends up linking in 2 or 3 or even 4 different HTTP clients.... ergh.

And thanks for the crate, it has been working perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants