Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce reliance on Ledger for Ledger wallets #7276

Open
skorokithakis opened this issue Jan 4, 2021 · 3 comments
Open

Reduce reliance on Ledger for Ledger wallets #7276

skorokithakis opened this issue Jan 4, 2021 · 3 comments

Comments

@skorokithakis
Copy link

It would be great if Monero could optionally store the view key on the device. My wallet is already protected by a passphrase, and I consider storing the encrypted view key on my computer an acceptable risk. This would make syncing and viewing balances much easier, since it would turn my wallet into basically a read-only softwallet, but still require the Ledger when sending funds.

I think this would be great for usability, since people usually view transactions more than they send funds. Another benefit is that you wouldn't have to have your Ledger open and connected for hours while the client syncs the blockchain, you could instead just connect the Ledger for the few seconds you need to sign a sending transaction and turn it off it afterwards.

@SamsungGalaxyPlayer
Copy link
Collaborator

@skorokithakis
Copy link
Author

@SamsungGalaxyPlayer thanks for that! It would appear that the Ledger is required for more than the key, as I had exported the key and removed the Ledger so the blockchain could download.

However, it turned out that the Ledger was still required (for block verification? I'm not sure, it never asked me for the key again).

Also, related issue: LedgerHQ/app-monero#27

@jonathancross
Copy link
Contributor

I agree that caching the private view key in the wallet would be a great option for most users.

Assuming a strong password is used for the wallet, I see no significant downside as compared to having the user manually export the view key every session -- both can be intercepted and stolen by malware on the desktop machine. If the user has a weak password and malware on the system, then there would be some risk of the wallet file being brute-forced, but for very little gain.

Users who are concerned about these sort of attacks should instead be filtering blocks through the Ledger device itself.

for block verification?

No, exporting the private view key allows your computer to "scan blocks looking for transactions".
If the key is not exported, then the Ledger device itself will need to scan blocks. This is dramatically slower (tiny processor with almost no RAM), but protects the view key from any potential malware running on your computer (a privacy consideration for some Monero users).

This is in contrast to Bitcoin where transactions are already public, so there is no significant loss of privacy if malware steals the view key (aka xpub).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants