Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not handle the getChildProjectUrlInheritAppendPath model property #412

Open
ppkarwasz opened this issue Apr 19, 2024 · 2 comments
Open

Comments

@ppkarwasz
Copy link
Contributor

The Maven Flatten Plugin does not handle the Model#getChildProjectUrlInheritAppendPath from the original POM and the property is always removed.

Since similar properties in the <scm> element are silently copied, whenever the element is copied, I believe that getChildProjectUrlInheritAppendPath should also always be copied.

@jam01
Copy link

jam01 commented Jul 4, 2024

Just ran into this general issue, however I'd suggest SCM drops the attributes instead.

Given my use of the flattened oss pom to give maven central a clean "consumption only" pom, the extra attributes are unnecessary.

In general, to flatten the pom should mean to remove them as well.

@ppkarwasz
Copy link
Contributor Author

I guess both behaviors should be supported:

  • if you are flattening a parent POM, these attributes should stay,
  • if you are flattening a JAR artifact, these attributes are no longer necessary and can be dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants