Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visualDiff of @web/test-runner-visual-regression can't be imported #2804

Open
jeripeierSBB opened this issue Sep 11, 2024 · 1 comment
Open

Comments

@jeripeierSBB
Copy link

Since version 0.10.0 of @web/test-runner-visual-regression typescript complains when trying to import visualDiff like: import { visualDiff } from '@web/test-runner-visual-regression'; (suggested by docs).

We assume that the index.d.ts which newly contains .mjs extension (export * from './browser/commands.mjs';) causes the problem. If the extension is removed, it works again.

Dependency update PR on our side with failing typescript:
PR: sbb-design-systems/lyne-components#3069
Logs: https://github.com/sbb-design-systems/lyne-components/actions/runs/10811479138/job/29990965173?pr=3069

@melink14
Copy link
Contributor

melink14 commented Dec 19, 2024

Is there any update or workaround for this?

I guess I can do a patch package...

My patch for future reference:

diff --git a/node_modules/@web/test-runner-visual-regression/index.d.ts b/node_modules/@web/test-runner-visual-regression/index.d.ts
index f540538..5198ffa 100644
--- a/node_modules/@web/test-runner-visual-regression/index.d.ts
+++ b/node_modules/@web/test-runner-visual-regression/index.d.ts
@@ -1,2 +1,2 @@
 // this file is autogenerated with the generate-mjs-dts-entrypoints script
-export * from './browser/commands.mjs';
+export * from './browser/commands';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants