Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain Validation issue for PR #166544 #166726

Closed
DeusMaximus opened this issue Aug 8, 2024 · 1 comment
Closed

Domain Validation issue for PR #166544 #166726

DeusMaximus opened this issue Aug 8, 2024 · 1 comment
Milestone

Comments

@DeusMaximus
Copy link
Contributor

Pull Request #166544 for the RSI Launcher has a domain validation issue, due to the publisher URL (cloudimperiumgames.com) not matching the package URL and download link (robertsspaceindustries.com).

In case proof is needed, you can visit https://cloudimperiumgames.com/games which links to both Star Citizen and Squadron 42's pages hosted on https://robertsspaceindustries.com/

The download link for the 2.0.2 launcher can also be found at https://robertsspaceindustries.com/download

There used to be a domain validation bypass for this package, but this may have been deleted when the old 1.x packages were removed from the repo.

From the microsoft-github-policy-service-bot's previous message:

          Hello @DeusMaximus,

One or more of the installer URLs doesn't appear valid.

This may happen for sites with policies prohibiting distribution or use by third parties.

This may happen for URLs pointing to domains that do not align with the publisher domain or package domain. If you could provide supporting evidence from the publisher that the URLs for the installer are correct, that would help us to validate and approve this PR.

Template: msftbot/validationError/urls/domain

Originally posted by @microsoft-github-policy-service[bot] in #166544 (comment)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Aug 8, 2024
@stephengillie
Copy link
Collaborator

Please understand that the automated response is somewhat incorrect. Generally, this just means that a human such as myself has to be able to navigate from the PackageUrl to the InstallerUrl.
#166544 (comment)

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Aug 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Aug 9, 2024
@denelon denelon added this to the 1.10 Packages milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants