Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically collapse asset panels if the open project has no assets of that type #68

Open
riknoll opened this issue Feb 15, 2023 · 1 comment
Assignees
Labels

Comments

@riknoll
Copy link
Member

riknoll commented Feb 15, 2023

When we open the asset explorer, we should collapse all of the empty entries to give more room for the asset actions. I'm sure there must be a vscode command for this somewhere.

We should also not expand anything automatically, as that would be annoying. Just collapse the empty ones.

@riknoll riknoll added the enhancement New feature or request label Feb 15, 2023
@abchatra abchatra added this to the First release of extension milestone Feb 15, 2023
@jwunderl
Copy link
Member

I don't think this can be done at the moment; looks like we need microsoft/vscode#88219 for programmatically setting expanded/collapsed state.

My reading is that if we want we could add "visibility": "collapsed" here so that all the {assetType}Explorers start collapsed (& which only sets the default for when first opening workspace / until first interaction by user), but I don't think that's what we want (well, it is, but we would want that to be used here ish https://github.com/microsoft/pxt-vscode-web/blob/main/src/web/jres.ts#L44)

@abchatra abchatra removed this from the First release of extension milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants