Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start MakeCode Simulator command should only appear in editor context menu if in a MakeCode project #154

Open
joyceerhl opened this issue Mar 21, 2023 · 1 comment
Open

Start MakeCode Simulator command should only appear in editor context menu if in a MakeCode project #154

joyceerhl opened this issue Mar 21, 2023 · 1 comment
Assignees
@jwunderl

Comments

@joyceerhl
Copy link

  1. Install MakeCode extension
  2. Open microsoft/vscode repo
  3. Open a TS file and right click to open context menu
  4. 🐛 see Start MakeCode Simulator in context menu

image

I would also suggest putting this command in a different group as currently it is grouped with unrelated go to definition actions. If there's only one MakeCode command it may make sense to group it with the other run/debug actions in the debug group, otherwise it could go into a dedicated MakeCode group.
@jwunderl jwunderl self-assigned this Mar 21, 2023
jwunderl added a commit that referenced this issue Mar 21, 2023
@jwunderl
only include context menu sim when in mkcd project, move to debug gro…
265c762 
…up re: #154
@jwunderl
Copy link
Member

Thanks for the suggestion! I added these changes into #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwunderl jwunderl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwunderl @joyceerhl