Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests hidden in VS Code's 'Explorer' cannot be found #44

Open
nils-soderman opened this issue Jul 26, 2024 · 2 comments
Open

Tests hidden in VS Code's 'Explorer' cannot be found #44

nils-soderman opened this issue Jul 26, 2024 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@nils-soderman
Copy link

nils-soderman commented Jul 26, 2024

To keep my VS Code explorer clean, I tend to exclude out & dist folders using the files.exclude setting. This however, leads to this extension failing to locate the tests as it relies on vscode.workspace.findFiles.

Maybe glob can be used instead to locate all tests on the filesystem?

Cheers,
Nils

@connor4312
Copy link
Member

connor4312 commented Jul 26, 2024

@andreamah is this something I can use the new findFiles2 API to fix? Sorry I lost track of where all the proposals are 🙈

Current usage is simple:

for (const file of await vscode.workspace.findFiles(relativePattern)) {

@andreamah
Copy link

andreamah commented Jul 26, 2024

Yes, you can use the new findFiles2 for this! You can use the existing shape for findFiles2 to achieve this right now, but I'd try to be ready to move to the new shape once I introduce it. You would just set useDefaultExcludes to false.

@connor4312 connor4312 self-assigned this Jul 26, 2024
@connor4312 connor4312 added the bug Issue identified by VS Code Team member as probable bug label Jul 26, 2024
@connor4312 connor4312 added this to the August 2024 milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants